[webkit-reviews] review denied: [Bug 237437] [WebGPU] Abide by the WebKit Style Guide : [Attachment 453758] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237437: [WebGPU] Abide by the WebKit Style Guide
https://bugs.webkit.org/show_bug.cgi?id=237437

Attachment 453758: Patch

https://bugs.webkit.org/attachment.cgi?id=453758&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 453758
  --> https://bugs.webkit.org/attachment.cgi?id=453758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453758&action=review

>>>> Source/WebGPU/ChangeLog:9
>>>> +	      1. "Donât add explicit initializations to nil"
>>> 
>>> Wait, what? What is that guideline?
>>> 
>>> Under ARC things are initialized without doing it explicitly, but with
manual retain/release I am pretty sure you need to do it!
>> 
>> https://webkit.org/code-style-guidelines/#zero-objc-variables
>> 
>> "In Objective-C, instance variables are initialized to zero automatically.
Don’t add explicit initializations to nil or NO in an init method."
> 
> Oh, maybe that's just for ivars and not regular variables?
> 
> And maybe doesn't apply in Objective-C++?

Yes, just instance variables. It does apply in Objective-C++, but structure
members and C++ class members are not instance variables.