[webkit-reviews] review granted: [Bug 237371] [web-animations] keyframe values set to "inherit" should recompute their values when the inherited value changes : [Attachment 453739] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237371: [web-animations] keyframe values set to "inherit" should recompute
their values when the inherited value changes
https://bugs.webkit.org/show_bug.cgi?id=237371

Attachment 453739: Patch

https://bugs.webkit.org/attachment.cgi?id=453739&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 453739
  --> https://bugs.webkit.org/attachment.cgi?id=453739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453739&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:788
> +	   for (auto& [property, value] : keyframe.styleStrings) {
> +	       if (CSSProperty::isInheritedProperty(property) && value ==
"inherit")
> +		   m_inheritedProperties.add(property);
> +	   }

Shouldn't this be || rather than &&?