[webkit-reviews] review granted: [Bug 237421] LibWebRTCCodecs::setEncodeRates should send LibWebRTCCodecsProxy::SetEncodeRates only when the encoder is live : [Attachment 453722] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 237421: LibWebRTCCodecs::setEncodeRates should send
LibWebRTCCodecsProxy::SetEncodeRates only when the encoder is live
https://bugs.webkit.org/show_bug.cgi?id=237421

Attachment 453722: Patch

https://bugs.webkit.org/attachment.cgi?id=453722&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 453722
  --> https://bugs.webkit.org/attachment.cgi?id=453722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453722&action=review

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:525
> +	       auto* encoder = m_encoders.get(encoderIdentifier);

If this is guaranteed non-null, then I suggest putting in a reference, not a
pointer. Maybe also add an assertion? Not clear to me why this is strongly
guaranteed.