[webkit-reviews] review granted: [Bug 237407] [iOS] Unable to scroll to a found text range when there is an existing selection : [Attachment 453696] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 3 09:31:09 PST 2022
Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 237407: [iOS] Unable to scroll to a found text range when there is an
existing selection
https://bugs.webkit.org/show_bug.cgi?id=237407
Attachment 453696: Patch
https://bugs.webkit.org/attachment.cgi?id=453696&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 453696
--> https://bugs.webkit.org/attachment.cgi?id=453696
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=453696&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600
> + TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling);
Nit - I think you can remove the `.get()` here.
More information about the webkit-reviews
mailing list