[webkit-reviews] review granted: [Bug 237378] Rendering issues with many dynamically-added sticky elements inside overflow scroll : [Attachment 453636] Patch

[bugzilla-daemon at webkit.org]

Cameron McCormack (:heycam) <heycam at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 237378: Rendering issues with many dynamically-added sticky elements inside
overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=237378

Attachment 453636: Patch

https://bugs.webkit.org/attachment.cgi?id=453636&action=review




--- Comment #2 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 453636
  --> https://bugs.webkit.org/attachment.cgi?id=453636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453636&action=review

r=me though I didn't read the tests closely.

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:382
> +    if (!rootStateNode())
> +	   return emptyString();

It's an unlikely error case but you might still want to log m_unparentedNodes
even if we have no root node?