[webkit-reviews] review granted: [Bug 237379] rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the legacy build system : [Attachment 453639] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 237379: rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the
legacy build system
https://bugs.webkit.org/show_bug.cgi?id=237379

Attachment 453639: Patch

https://bugs.webkit.org/attachment.cgi?id=453639&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 453639
  --> https://bugs.webkit.org/attachment.cgi?id=453639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453639&action=review

> Source/WTF/Configurations/Base.xcconfig:116
> +DEPLOYMENT_TARGET_CLANG_ENV_NAME_legacy[sdk=watch*] =
WATCHOS_DEPLOYMENT_TARGET;

Don't we need tvOS all over the place?

I also wonder if a temporary hack in HaveInternalSDK.xcconfig would be better
than having this all over the place.