[webkit-reviews] review granted: [Bug 237346] REGRESSION(r290539): [ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures : [Attachment 453546] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237346: REGRESSION(r290539): [ iOS ] 2X
http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are
constant text failures
https://bugs.webkit.org/show_bug.cgi?id=237346

Attachment 453546: Patch

https://bugs.webkit.org/attachment.cgi?id=453546&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 453546
  --> https://bugs.webkit.org/attachment.cgi?id=453546
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453546&action=review

r=me

> LayoutTests/ChangeLog:10
> +	   we've changed behavior such that creation still succeeds with none
attestation

Nit: Maybe say: "... succeeds with 'none' attestation in this case..."