[webkit-reviews] review granted: [Bug 237353] Add test coverage for deleting FileSystem data when file is being written : [Attachment 453572] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237353: Add test coverage for deleting FileSystem data when file is being
written
https://bugs.webkit.org/show_bug.cgi?id=237353

Attachment 453572: Patch

https://bugs.webkit.org/attachment.cgi?id=453572&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 453572
  --> https://bugs.webkit.org/attachment.cgi?id=453572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453572&action=review

> Tools/ChangeLog:8
> +	   Verify that file can be removed from disk, and active
FileSystemSyncAccessHandle is invalidated in ths case.

Typo: "ths"

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:208
> +	   RetainPtr<NSData> data;

Why declare the variable here?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:212
> +	   data = [NSData dataWithBytes:workerBytes
length:strlen(workerBytes)];

RetainPtr data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)];