[webkit-reviews] review granted: [Bug 237357] [web-animations] changes to font-size should recompute keyframes : [Attachment 453581] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237357: [web-animations] changes to font-size should recompute keyframes
https://bugs.webkit.org/show_bug.cgi?id=237357

Attachment 453581: Patch

https://bugs.webkit.org/attachment.cgi?id=453581&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 453581
  --> https://bugs.webkit.org/attachment.cgi?id=453581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453581&action=review

> Source/WebCore/animation/KeyframeEffectStack.cpp:146
> -	   if (propertyAffectingLogicalPropertiesChanged)
> -	      
effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle,
resolutionContext);
> +	   if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged)
> +	      
effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle,
resolutionContext);

This is probably incomplete as various other things can affect unit resolution
(like zoom property).