[webkit-reviews] review granted: [Bug 237341] [libpas] Add missing PlayStation implementation. : [Attachment 453539] PATCH

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 237341: [libpas] Add missing PlayStation implementation.
https://bugs.webkit.org/show_bug.cgi?id=237341

Attachment 453539: PATCH

https://bugs.webkit.org/attachment.cgi?id=453539&action=review




--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 453539
  --> https://bugs.webkit.org/attachment.cgi?id=453539
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=453539&action=review

>>> Source/bmalloc/libpas/src/libpas/pas_monotonic_time.c:89
>>> +	 return ts.tv_sec * 1.0e9 + ts.tv_nsec;
>> 
>> Do you really want to do floating point double precision multiplication
here, and then convert back to integer? Maybe uint64_t multiplication would be
better?
> 
> Yusuke, what do you think? I think Darin's point is reasonable, but any
reason to use float? I've followed Linux implementation.

I think either is fine.