[webkit-reviews] review granted: [Bug 235017] Web app fails only when dev tools is open : [Attachment 453469] Patch v1.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 11:37:57 PST 2022


Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 235017: Web app fails only when dev tools is open
https://bugs.webkit.org/show_bug.cgi?id=235017

Attachment 453469: Patch v1.1

https://bugs.webkit.org/attachment.cgi?id=453469&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 453469
  --> https://bugs.webkit.org/attachment.cgi?id=453469
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=453469&action=review

r=me

> Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp:223
> +    // `event.target()->injectedScript()` can change between
`willHandleEvent` and `didHandleEvent`. The

NIT: I think you meant `scriptExecutionContext()`? ��

> Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp:267
> +    // `event.target()->injectedScript()` can change between
`willHandleEvent` and `didHandleEvent`. Here it could also

ditto (:223)


More information about the webkit-reviews mailing list