[webkit-reviews] review denied: [Bug 237311] Unable to set logging channel levels through NSUserDefaults in Release builds : [Attachment 453479] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 10:44:19 PST 2022


Jer Noble <jer.noble at apple.com> has denied  review:
Bug 237311: Unable to set logging channel levels through NSUserDefaults in
Release builds
https://bugs.webkit.org/show_bug.cgi?id=237311

Attachment 453479: Patch

https://bugs.webkit.org/attachment.cgi?id=453479&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 453479
  --> https://bugs.webkit.org/attachment.cgi?id=453479
Patch

Moving from r+ to r-; reading NSDefaults during process launch has caused
process launch time regressions in the past. See bug #185951 for context.

With the change from r290654 in place, we should only be reading NSDefaults
once during app launch, then never again, so this change should be unnecessary.


More information about the webkit-reviews mailing list