[webkit-reviews] review granted: [Bug 237303] Fix Speedometer's setTimeout throttling issue : [Attachment 453463] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 237303: Fix Speedometer's setTimeout throttling issue
https://bugs.webkit.org/show_bug.cgi?id=237303

Attachment 453463: Patch

https://bugs.webkit.org/attachment.cgi?id=453463&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 453463
  --> https://bugs.webkit.org/attachment.cgi?id=453463
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453463&action=review

r=me

I think Yusuke resolved Chris's comment; please correct me if not.

> PerformanceTests/Speedometer/resources/benchmark-runner.js:57
> +	   if (element) {
> +	       window.requestAnimationFrame(function () {
> +		   return promise.resolve(element);
> +	       });
> +	       return;
> +	   }

The change to _runTest (below) ensures that each test ends with zero timer
nesting level.

I think the purpose of this change is to ensure that each test also begins with
zero timer nesting level?

Seems like a reasonable solution. But I'm curious, to help with my own mental
model: Did you discover a specific case where just one of these changes or the
other alone was insufficient?