[webkit-reviews] review granted: [Bug 237300] Move StorageBucket function definitions outside the class definition : [Attachment 453466] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237300: Move StorageBucket function definitions outside the class
definition
https://bugs.webkit.org/show_bug.cgi?id=237300

Attachment 453466: Patch

https://bugs.webkit.org/attachment.cgi?id=453466&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 453466
  --> https://bugs.webkit.org/attachment.cgi?id=453466
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453466&action=review

r=me

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:115
> +    return ""_s;

emptyString()

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:166
> +    return m_localStorageManager.get();

This is a one liner, I think we should keep it inline within the class
definition.

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:179
> +    return m_sessionStorageManager.get();

ditto.

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:192
> +    return m_idbStorageManager.get();

ditto.