[webkit-reviews] review granted: [Bug 240325] REGRESSION (r293933): [ iOS Debug ][ macOS Debug wk2 ] ASSERTION FAILED: m_requestCount > -1 : [Attachment 460513] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 28 09:41:51 PDT 2022
Antti Koivisto <koivisto at iki.fi> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 240325: REGRESSION (r293933): [ iOS Debug ][ macOS Debug wk2 ] ASSERTION
FAILED: m_requestCount > -1
https://bugs.webkit.org/show_bug.cgi?id=240325
Attachment 460513: Patch
https://bugs.webkit.org/attachment.cgi?id=460513&action=review
--- Comment #13 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 460513
--> https://bugs.webkit.org/attachment.cgi?id=460513
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=460513&action=review
> Source/WebCore/loader/cache/CachedResourceLoader.cpp:1078
> + subresourceLoader->clearRequestCountTracker();
> resource->setIgnoreForRequestCount(false);
> - incrementRequestCount(*resource);
> + subresourceLoader->resetRequestCountTracker(*this, *resource);
I feel there is a less confusing factoring for this that involves not making a
request count tracker at all when you are ignoring request counts.
More information about the webkit-reviews
mailing list