[webkit-reviews] review requested: [Bug 241920] canPlayType and video codec filtering fail for VP8 on Mac with VP8 but not VP9 hardware codecs : [Attachment 460448] Untested provisional patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 10:01:49 PDT 2022


Brion Vibber <bvibber at wikimedia.org> has asked	for review:
Bug 241920: canPlayType and video codec filtering fail for VP8 on Mac with VP8
but not VP9 hardware codecs
https://bugs.webkit.org/show_bug.cgi?id=241920

Attachment 460448: Untested provisional patch

https://bugs.webkit.org/attachment.cgi?id=460448&action=review




--- Comment #3 from Brion Vibber <bvibber at wikimedia.org> ---
Created attachment 460448

  --> https://bugs.webkit.org/attachment.cgi?id=460448&action=review

Untested provisional patch

I put together this patch the other day after finding what looks like a
suspicious ordering of operations, however I'm unable to test it because my
WebKit builds don't appear to support WebM video files at all. I would
appreciate help with this, such as confirmation of the bug, the functionality
of the patch, and how to build WebKit with WebM support on macOS. Thanks!


More information about the webkit-reviews mailing list