[webkit-reviews] review granted: [Bug 241879] REGRESSION (251257 at main): [ macOS wk1 ] fast/replaced/encrypted-pdf-as-object-and-embed.html is a flaky crash : [Attachment 460441] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 241879: REGRESSION (251257 at main): [ macOS wk1 ]
fast/replaced/encrypted-pdf-as-object-and-embed.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=241879

Attachment 460441: Patch

https://bugs.webkit.org/attachment.cgi?id=460441&action=review




--- Comment #7 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 460441
  --> https://bugs.webkit.org/attachment.cgi?id=460441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460441&action=review

> Source/WebCore/style/StyleScope.cpp:799
> -    ASSERT(m_document.renderView());
> +
> +    if (!m_document.renderView())
> +	   return false;

Would be nice to explain whether this assertion was always incorrect or if it
changed to no longer be correct. Either way, would be good to know why this
change was required.