[webkit-reviews] review denied: [Bug 241681] Assorted build-time warnings fixes : [Attachment 460270] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 07:50:45 PDT 2022

Mark Lam <mark.lam at apple.com> has denied Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 241681: Assorted build-time warnings fixes

Attachment 460270: Patch


--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 460270
  --> https://bugs.webkit.org/attachment.cgi?id=460270

View in context: https://bugs.webkit.org/attachment.cgi?id=460270&action=review

> Source/JavaScriptCore/bytecode/Repatch.cpp:1818
> +		   if (callCase.codeBlock()) {

Wrong fix.  The right thing to do is to use codeBlock in the body below.

More information about the webkit-reviews mailing list