[webkit-reviews] review granted: [Bug 241369] [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry : [Attachment 460062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 11:25:57 PDT 2022

Mark Lam <mark.lam at apple.com> has granted Geza Lore <glore at igalia.com>'s
request for review:
Bug 241369: [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry

Attachment 460062: Patch


--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 460062
  --> https://bugs.webkit.org/attachment.cgi?id=460062

View in context: https://bugs.webkit.org/attachment.cgi?id=460062&action=review

r=me with comment fix up.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:776
> +    # but are not in RegisterSet::vmCalleeSaveRegisters() need to be saved
> +    # I.e.: Only those registers that are callee save in the C ABI, but are
> +    # callee save in teh JIT ABI.

nit: "here. I.e.: Only" -> "here i.e. only".


More information about the webkit-reviews mailing list