[webkit-reviews] review granted: [Bug 241323] [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content : [Attachment 460044] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has granted  review:
Bug 241323: [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and
content
https://bugs.webkit.org/show_bug.cgi?id=241323

Attachment 460044: Patch

https://bugs.webkit.org/attachment.cgi?id=460044&action=review




--- Comment #2 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 460044
  --> https://bugs.webkit.org/attachment.cgi?id=460044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460044&action=review

nice

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:697
> +	   if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned())

I'm pretty sure `float` has no effect on flex items. See:

data:text/html,<div style="display: flex;"><div style="float: right; width:
200px; height: 200px; background: red"></div></div>

or 

data:text/html,<div style="display:
flex;">dsdfdsofjdskfdslvndlcvnfsldjnvdfoskgdfjngfdjnfdljgksdfngfdlg<div
style="float: left; width: 200px; height: 200px; background: red"></div></div>

I could be wrong though