[webkit-reviews] review denied: [Bug 241309] Set MallocProbGuard env var when running API tests and layout tests in Debug configuration : [Attachment 460030] Patch v2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 241309: Set MallocProbGuard env var when running API tests and layout tests
in Debug configuration
https://bugs.webkit.org/show_bug.cgi?id=241309

Attachment 460030: Patch v2

https://bugs.webkit.org/attachment.cgi?id=460030&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 460030
  --> https://bugs.webkit.org/attachment.cgi?id=460030
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=460030&action=review

> COMMIT_MESSAGE:1
> +Set MallocProbGuard env var when running API tests and layout tests in Debug
configuration 

What is the performance impact of this? Debug tests are already so slow that
there zero space for nice to have things. 

Also, anything that simply increases flakiness is a no-go. This is what fuzzing
infra is for; for regular tests, the goal is to reduce flakiness.