[webkit-reviews] review denied: [Bug 217802] Unify CSS property enablement (-apple-color-filter should not exist on CSSStyleDeclaration by default) : [Attachment 459818] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 217802: Unify CSS property enablement (-apple-color-filter should not exist
on CSSStyleDeclaration by default)
https://bugs.webkit.org/show_bug.cgi?id=217802

Attachment 459818: Patch

https://bugs.webkit.org/attachment.cgi?id=459818&action=review




--- Comment #53 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 459818
  --> https://bugs.webkit.org/attachment.cgi?id=459818
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459818&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.h:149
> +    FixedVector<CSSPropertyID> m_activeComputedPropertyIDs;

This is a vector containing every active CSSPropertyID so ~500 entries and 2
bytes per entry so ~1KB. This is being constructed from scratch for every style
declaration created (which there can unbounded number). This seems way
excessive in terms of both memory and processing time. The content of the
vector is dependent on settings only so this structure should be per-document,
not per declaration.