[webkit-reviews] review granted: [Bug 234118] REGRESSION(r286765): [Cairo][GTK][WPE] Various SVG tests that use filters fail : [Attachment 459878] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 234118: REGRESSION(r286765): [Cairo][GTK][WPE] Various SVG tests that use
filters fail
https://bugs.webkit.org/show_bug.cgi?id=234118

Attachment 459878: Patch

https://bugs.webkit.org/attachment.cgi?id=459878&action=review




--- Comment #9 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 459878
  --> https://bugs.webkit.org/attachment.cgi?id=459878
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459878&action=review

r=me with feedback

> Source/WTF/wtf/PlatformEnable.h:248
> -#define ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB 1
> +#define ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB 0

My only concern here is that this might affect Apple ports.

Could we do

#if USE(CAIRO)
#define ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB 0
#else
#define ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB 1
#endif