[webkit-reviews] review granted: [Bug 241231] Regression(r294902) Web Inspector highlight gets stuck when hovering over items. : [Attachment 459967] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 241231: Regression(r294902) Web Inspector highlight gets stuck when
hovering over items.
https://bugs.webkit.org/show_bug.cgi?id=241231

Attachment 459967: Patch

https://bugs.webkit.org/attachment.cgi?id=459967&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 459967
  --> https://bugs.webkit.org/attachment.cgi?id=459967
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459967&action=review

> COMMIT_MESSAGE:14
> +This problem could be addressed in a few different ways including
> +- RenderLayer d'tor should always issue repaint when the "full repaint" flag
is set (we may not be able to resolve the coordinates in d'tor)
> +- call force repaint on the renderer and ignore the repaint optimization
(hard to tell when to use forced repaint)
> +- make sure repaint is actually issued before destroying the layer (local
change. We may make the same mistake again)

This level of detail might be better in the bug, rather than the commit
message.

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:-957
> -	   // We only repaint |child| if we have a RenderLayer as its visual
overflow may not be tracked by its parent.

I guess this comment was stale? I see no layer checks here.