[webkit-reviews] review granted: [Bug 241225] [CSS Container Queries] Re-evaluate queries after subframe size changes : [Attachment 459959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 09:01:23 PDT 2022

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 241225: [CSS Container Queries] Re-evaluate queries after subframe size

Attachment 459959: Patch


--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 459959
  --> https://bugs.webkit.org/attachment.cgi?id=459959

View in context: https://bugs.webkit.org/attachment.cgi?id=459959&action=review

> Source/WebCore/page/FrameViewLayoutContext.h:58
> +    void layoutWithoutUpdatingQueryContainers();

I assume we are not planning on introducing too many new layout() callsites, so
in practice having these 2 functions and deciding "which one to call when"
won't cause any issues -but in theory it may be a bit puzzling which one to
actually use. I guess if you don't know whether you need query containers, it's
better to just use layout().

More information about the webkit-reviews mailing list