[webkit-reviews] review granted: [Bug 243197] [LFC][IFC] Inconsistent integral rounding of baseline relative logical top values : [Attachment 461222] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 243197: [LFC][IFC] Inconsistent integral rounding of baseline relative
logical top values
https://bugs.webkit.org/show_bug.cgi?id=243197

Attachment 461222: Patch

https://bugs.webkit.org/attachment.cgi?id=461222&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 461222
  --> https://bugs.webkit.org/attachment.cgi?id=461222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461222&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:127
> +    void setLogicalTop(InlineLayoutUnit logicalTop) { logicalTop >= 0 ?
m_logicalRect.setTop(roundToInt(logicalTop)) :
m_logicalRect.setTop(-roundToInt(-logicalTop)); }

I think you want ?: inside setTop