[webkit-reviews] review granted: [Bug 243134] Fix aspect-ratio/fieldset-element-001.html : [Attachment 461179] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 25 16:37:27 PDT 2022
Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 243134: Fix aspect-ratio/fieldset-element-001.html
https://bugs.webkit.org/show_bug.cgi?id=243134
Attachment 461179: Patch
https://bugs.webkit.org/attachment.cgi?id=461179&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 461179
--> https://bugs.webkit.org/attachment.cgi?id=461179
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=461179&action=review
> Source/WebCore/rendering/RenderBox.cpp:3193
> - *intrinsicHeight -= borderAndPaddingLogicalHeight();
> + *intrinsicHeight -= RenderBox::borderBefore() +
RenderBox::paddingBefore() + RenderBox::borderAfter() +
RenderBox::paddingAfter();
Obviously OK here, but are we sure that none of the other clients of
borderAndPaddingLogicalHeight() need this adjustment?
If it was used anywhere else we’d want a named function rather than a long
list.
More information about the webkit-reviews
mailing list