[webkit-reviews] review granted: [Bug 236061] The background of the main frame's transparent custom scrollbar should be filled with the view background color if !HAVE(RUBBER_BANDING) : [Attachment 461108] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 236061: The background of the main frame's transparent custom scrollbar
should be filled with the view background color if !HAVE(RUBBER_BANDING)
https://bugs.webkit.org/show_bug.cgi?id=236061

Attachment 461108: Patch

https://bugs.webkit.org/attachment.cgi?id=461108&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 461108
  --> https://bugs.webkit.org/attachment.cgi?id=461108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461108&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3655
> +    if (backgroundColor.isValid())

In cases like this, I think it’s good to use isVisible() instead of isValid().
That’s guaranteed to return false for invalid color, but also returns false for
fully transparent colors which don’t need painting.

On the other hand, maybe fillRect() already does an isVisible() check (I didn’t
look). In that case, we don’t need the isValid() check either.