[webkit-reviews] review granted: [Bug 235838] [macOS] Expose screen and window capture state to WKWebView : [Attachment 450439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 14:15:16 PST 2022

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 235838: [macOS] Expose screen and window capture state to WKWebView

Attachment 450439: Patch


--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 450439
  --> https://bugs.webkit.org/attachment.cgi?id=450439

Probably worth adding a test validating we delay with a timer the start
capture/stop capture.
While this is mostly useful for camera, it is good to validate this will work
for display as well.

Another question worth exploring. We might add in the future getViewPortMedia
which is specific to capturing the self tab.
We probably want a different delegate, but it may be ok to keep the same
display states/mutators APIs.

View in context: https://bugs.webkit.org/attachment.cgi?id=450439&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4873
> +    UNUSED_PARAM(isFromDisplayCapture);

FIXME: Remove isFromDisplayCapture?

More information about the webkit-reviews mailing list