[webkit-reviews] review granted: [Bug 235882] ServiceWorkerNavigationPreloader should only be used once : [Attachment 450394] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 31 11:41:50 PST 2022
Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 235882: ServiceWorkerNavigationPreloader should only be used once
https://bugs.webkit.org/show_bug.cgi?id=235882
Attachment 450394: Patch
https://bugs.webkit.org/attachment.cgi?id=450394&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 450394
--> https://bugs.webkit.org/attachment.cgi?id=450394
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=450394&action=review
> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:398
> + RELEASE_LOG_ERROR(ServiceWorker,
"ServiceWorkerFetchTask::loadBodyFromPreloader preloader is null");
Could you please add a SWFETCH_RELEASE_LOG_ERROR() for consistency with
SWFETCH_RELEASE_LOG()?
More information about the webkit-reviews
mailing list