[webkit-reviews] review granted: [Bug 235844] Collapsed ranges return zero rects in DocumentContext : [Attachment 450291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 11:20:47 PST 2022

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 235844: Collapsed ranges return zero rects in DocumentContext

Attachment 450291: Patch


--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 450291
  --> https://bugs.webkit.org/attachment.cgi?id=450291

View in context: https://bugs.webkit.org/attachment.cgi?id=450291&action=review

> Source/WebKit/ChangeLog:12
> +	   This results in an understandable zero rect for the absolute
bounding rects for that character,
> +	   which is not really representative of what the bounding rect is. For
these situations, we should

Some reference back to the change you made that broke this would be good.
("Before revision X, we did A; afterwards, we did B, but that's a problem
because C" instead of this form that only captures C). You and I know the
context right now, but it's going to be quickly lost if not recorded here.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4576
> +		       absoluteBoundingBox =

is it really right to be adding new `makeDeprecatedLegacyPosition`?

More information about the webkit-reviews mailing list