[webkit-reviews] review granted: [Bug 235881] [CSS Container Queries] Check for query containers when matching rules : [Attachment 450392] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 235881: [CSS Container Queries] Check for query containers when matching
rules
https://bugs.webkit.org/show_bug.cgi?id=235881

Attachment 450392: Patch

https://bugs.webkit.org/attachment.cgi?id=450392&action=review




--- Comment #4 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 450392
  --> https://bugs.webkit.org/attachment.cgi?id=450392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450392&action=review

r+ but you'll probably want to account for Tim's comments as well.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/c
ontainer-type-invalidation-expected.txt:3
> +FAIL Changing the container type invalidates relevant descendants
assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"

What an odd change!