[webkit-reviews] review granted: [Bug 235867] Delete runtime preference for enabling keygen element : [Attachment 450341] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 29 16:44:53 PST 2022

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 235867: Delete runtime preference for enabling keygen element

Attachment 450341: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 450341
  --> https://bugs.webkit.org/attachment.cgi?id=450341

View in context: https://bugs.webkit.org/attachment.cgi?id=450341&action=review

r=me, no idea why tests are failing, but we have to deal with that.

> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:-177
> -    macro(HTMLSlotElement) \

This change isn’t mentioned in the change log. Maybe a good idea, but I don’t
see the explanation.

> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:2086
> +    return true;

Maybe false is better?

More information about the webkit-reviews mailing list