[webkit-reviews] review granted: [Bug 221083] EnterPictureInPictureEvent event was renamed to PictureInPictureEvent in spec : [Attachment 450269] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 221083: EnterPictureInPictureEvent event was renamed to
PictureInPictureEvent in spec
https://bugs.webkit.org/show_bug.cgi?id=221083

Attachment 450269: Patch

https://bugs.webkit.org/attachment.cgi?id=450269&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 450269
  --> https://bugs.webkit.org/attachment.cgi?id=450269
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450269&action=review

r=me, worth checking API test results though.


> Source/WebCore/ChangeLog:11
> +	   (https://github.com/w3c/picture-in-picture/issues/188)

Not sure how much of this is tested in WPT tests but maybe it is already
covered and we should just resync the corresponding WPT tests.

> Source/WebCore/ChangeLog:13
> +	   Covered by
media/picture-in-picture/picture-in-picture-api-events.html.

PictureInPictureEvent new name is not covered though.
Can we update LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/
to take benefit of the IDL harness coverage?
I would hope the IDL harness coverage test to be runnable without any issue.