[webkit-reviews] review granted: [Bug 221083] EnterPictureInPictureEvent event was renamed to PictureInPictureEvent in spec : [Attachment 450269] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 29 01:50:54 PST 2022

youenn fablet <youennf at gmail.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 221083: EnterPictureInPictureEvent event was renamed to
PictureInPictureEvent in spec

Attachment 450269: Patch


--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 450269
  --> https://bugs.webkit.org/attachment.cgi?id=450269

View in context: https://bugs.webkit.org/attachment.cgi?id=450269&action=review

r=me, worth checking API test results though.

> Source/WebCore/ChangeLog:11
> +	   (https://github.com/w3c/picture-in-picture/issues/188)

Not sure how much of this is tested in WPT tests but maybe it is already
covered and we should just resync the corresponding WPT tests.

> Source/WebCore/ChangeLog:13
> +	   Covered by

PictureInPictureEvent new name is not covered though.
Can we update LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/
to take benefit of the IDL harness coverage?
I would hope the IDL harness coverage test to be runnable without any issue.

More information about the webkit-reviews mailing list