[webkit-reviews] review granted: [Bug 234282] Remove showModalDialog-specific logic from JSDOMWindow::getOwnPropertySlot() : [Attachment 449961] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<ashvayka at apple.com>'s request for review:
Bug 234282: Remove showModalDialog-specific logic from
JSDOMWindow::getOwnPropertySlot()
https://bugs.webkit.org/show_bug.cgi?id=234282

Attachment 449961: Patch

https://bugs.webkit.org/attachment.cgi?id=449961&action=review




--- Comment #16 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 449961
  --> https://bugs.webkit.org/attachment.cgi?id=449961
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449961&action=review

Ah, I misunderstood. r=me

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:510
> +    return encodedJSUndefined();

Use { } in new code.

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:528
> +	   return encodedJSUndefined();

Use { } in new code.