[webkit-reviews] review granted: [Bug 235693] Migrate _UITextSearching implementation to be backed by WebFoundTextRangeController : [Attachment 450208] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 235693: Migrate _UITextSearching implementation to be backed by
WebFoundTextRangeController
https://bugs.webkit.org/show_bug.cgi?id=235693

Attachment 450208: Patch

https://bugs.webkit.org/attachment.cgi?id=450208&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 450208
  --> https://bugs.webkit.org/attachment.cgi?id=450208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450208&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10084
> +    _page->findTextRangesForStringMatches(string, findOptions, 1000,
[string, aggregator = retainPtr(aggregator)](const
Vector<WebKit::WebFoundTextRange> ranges) {

Not a regression but kind of odd that this `1000` is just chilling here inline
without a name.