[webkit-reviews] review granted: [Bug 235754] Ensure session is added in network process when it creates connection to web process : [Attachment 450243] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 235754: Ensure session is added in network process when it creates
connection to web process
https://bugs.webkit.org/show_bug.cgi?id=235754

Attachment 450243: Patch

https://bugs.webkit.org/attachment.cgi?id=450243&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 450243
  --> https://bugs.webkit.org/attachment.cgi?id=450243
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450243&action=review

r=me

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1351
> +	   send(Messages::NetworkProcess::AddWebsiteDataStore {
store.parameters() }, 0,
IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);

Would be nice to add a comment in the code to explain why
DispatchMessageEvenWhenWaitingForSyncReply is needed.