[webkit-reviews] review granted: [Bug 235760] [GStreamer] GstStructure to JSON serialization : [Attachment 450217] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 235760: [GStreamer] GstStructure to JSON serialization
https://bugs.webkit.org/show_bug.cgi?id=235760

Attachment 450217: Patch

https://bugs.webkit.org/attachment.cgi?id=450217&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 450217
  --> https://bugs.webkit.org/attachment.cgi?id=450217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450217&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:556
> +	   auto resultArray = array->asArray();
> +	   return resultArray->asValue();

I would collapse these two lines if possible.

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:322
> +String structureToJSONString(const GstStructure*);

I might go (not only for this method, but for the other ones as well) for
something like gstStructureTo...

> Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:57
> +    ASSERT_EQ(jsonString,
"{\"int-val\":5,\"str-val\":\"foo\",\"bool-val\":1}");

Are we not interested in printing the structure name?