[webkit-reviews] review granted: [Bug 235741] Web Inspector: Add another Protocol Version (iOS 15.4) : [Attachment 450189] Patch v1.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 15:37:47 PST 2022


Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 235741: Web Inspector: Add another Protocol Version (iOS 15.4)
https://bugs.webkit.org/show_bug.cgi?id=235741

Attachment 450189: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=450189&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 450189
  --> https://bugs.webkit.org/attachment.cgi?id=450189
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=450189&action=review

r=me, awesome!

>
Source/WebInspectorUI/UserInterface/Protocol/Legacy/15.4/InspectorBackendComman
ds.js:37
> +InspectorBackend.registerCommand("Animation.requestEffectTarget", null,
[{"name": "animationId", "type": "string"}], ["nodeId"]);

Since this is still `nodeId`, we should update the comment in
`WI.Animation.prototype.requestEffectTarget` to say "iOS 15.4" instead.


More information about the webkit-reviews mailing list