[webkit-reviews] review granted: [Bug 235691] Introduce WebFoundTextRange and WebFoundTextRangeController to support restorable find results : [Attachment 450177] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 235691: Introduce WebFoundTextRange and WebFoundTextRangeController to
support restorable find results
https://bugs.webkit.org/show_bug.cgi?id=235691

Attachment 450177: Patch

https://bugs.webkit.org/attachment.cgi?id=450177&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 450177
  --> https://bugs.webkit.org/attachment.cgi?id=450177
Patch

r=mews

(In reply to Aditya Keerthi from comment #5)
> (In reply to Wenson Hsieh from comment #3)
> > Comment on attachment 450162 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=450162&action=review
> > 
> > > Source/WebKit/Shared/WebFindOptions.cpp:31
> > > +WebCore::FindOptions core(OptionSet<FindOptions> options)
> > 
> > Nit - should probably either add a few more WebCore:: in this function, or
> > add a `using namespace WebCore;` instead. I think right now it might be
> > getting the missing WebCore:: from earlier unified sources.
> 
> I see any missing WebCore:: here, the parameter is in the WebKit namespace.

LGTM — I missed that these were different types altogether.