[webkit-reviews] review granted: [Bug 234018] nullptr deref in ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded : [Attachment 450152] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 234018: nullptr deref in
ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffset
IfNeeded
https://bugs.webkit.org/show_bug.cgi?id=234018

Attachment 450152: Patch

https://bugs.webkit.org/attachment.cgi?id=450152&action=review




--- Comment #33 from Darin Adler <darin at apple.com> ---
Comment on attachment 450152
  --> https://bugs.webkit.org/attachment.cgi?id=450152
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450152&action=review

> Source/WebCore/ChangeLog:3
> +	   nullptr deref in
ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffset
IfNeeded

This doesn’t seem the right title any more. At this point, this patch is a
refactor so the title would be:

    Simplify code by using inclusiveDescendantsOfType

The reason I suggested fixing the const, is that it’s a similar refactoring,
but fine to do this one step at a time.