[webkit-reviews] review granted: [Bug 235706] [GTK] Support accent colors : [Attachment 450127] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 235706: [GTK] Support accent colors
https://bugs.webkit.org/show_bug.cgi?id=235706

Attachment 450127: Patch

https://bugs.webkit.org/attachment.cgi?id=450127&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 450127
  --> https://bugs.webkit.org/attachment.cgi?id=450127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450127&action=review

> Source/WebCore/ChangeLog:9
> +	   here. Remove the last bits of ThemeGtk and foreign drawing on GTK3.

You haven't really removed the last bits, since we still draw GTK-style
scrollbars.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1847
> +#if USE(GTK4)
> +static void webkitWebViewBaseCssChanged(GtkWidget* widget,
GtkCssStyleChange* change)
> +#else
> +static void webkitWebViewBaseStyleUpdated(GtkWidget* widget)
> +#endif
> +{
> +#if USE(GTK4)
> +    GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->css_changed(widget,
change);
> +#else
> +   
GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->style_updated(widget);
> +#endif
> +
> +    WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
> +    WebKitWebViewBasePrivate* priv = webViewBase->priv;
> +    priv->pageProxy->accentColorDidChange();
> +}

Style nit: it's more readable to duplicate this short function for GTK 4 vs.
GTK 3 than to have all the #ifs inside of it.