[webkit-reviews] review granted: [Bug 235701] [WPE][a11y] Add option to build with ATSPI : [Attachment 450119] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 235701: [WPE][a11y] Add option to build with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=235701

Attachment 450119: Patch

https://bugs.webkit.org/attachment.cgi?id=450119&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 450119
  --> https://bugs.webkit.org/attachment.cgi?id=450119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450119&action=review

> Source/WebCore/PlatformWPE.cmake:127
> +    )

IIRC we have a similar (if not the same) custom command in PlatformGTK.cmake;
it would be nice to factor out this functionality in a CMake function at some
point. Could be a follow up patch later on.

> Source/cmake/OptionsWPE.cmake:90
> +WEBKIT_OPTION_DEFINE(USE_ATSPI "Whether to use the Atspi a11y implementation
instead of ATK." PRIVATE OFF)

Typo: Atspi → ATSPI

(All caps because it is an acronym, wasn't it?)