[webkit-reviews] review granted: [Bug 235663] Generated xcfilelists contain symlinks when building for macOS : [Attachment 450061] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 235663: Generated xcfilelists contain symlinks when building for macOS
https://bugs.webkit.org/show_bug.cgi?id=235663

Attachment 450061: Patch

https://bugs.webkit.org/attachment.cgi?id=450061&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 450061
  --> https://bugs.webkit.org/attachment.cgi?id=450061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450061&action=review

> Source/WebCore/Configurations/Base.xcconfig:152
> +WK_VERSIONED_BUNDLE[sdk=macosx*] = Versions/A;

I wonder if it would make more sense to name this WK_CONTENT_PATH_IN_FRAMEWORK
or something.

Also, if you make it "Versions/A/" then you can avoid having "//" in paths in
the embedded case.