[webkit-reviews] review granted: [Bug 235674] Symbols not always properly hidden when using WebKitAdditions to introduce new API : [Attachment 450070] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 235674: Symbols not always properly hidden when using WebKitAdditions to
introduce new API
https://bugs.webkit.org/show_bug.cgi?id=235674

Attachment 450070: Patch

https://bugs.webkit.org/attachment.cgi?id=450070&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 450070
  --> https://bugs.webkit.org/attachment.cgi?id=450070
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450070&action=review

> Source/WebKit/mac/replace-webkit-additions-includes.py:93
> +    additions_import_pattern = re.compile(r"\#if
ENABLE\(API_WEBKIT_ADDITIONS\)\n#import <WebKitAdditions/(.*)>\n#endif")

(Not necessarily in this patch, but) I wonder if it's even worth throwing a

#if ENABLE(API_WEBKIT_ADDITIONS)
#error "…"
#endif

…somewhere. Not exactly sure where, though.