[webkit-reviews] review granted: [Bug 235600] Capturing WebGL canvas through peer connection shows the image flipped : [Attachment 450043] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 235600: Capturing WebGL canvas through peer connection shows the image
flipped
https://bugs.webkit.org/show_bug.cgi?id=235600

Attachment 450043: Patch

https://bugs.webkit.org/attachment.cgi?id=450043&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 450043
  --> https://bugs.webkit.org/attachment.cgi?id=450043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450043&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:556
> +    // TODO: When this is moved to GraphicsContextGLCocoa, set
m_mediaSampleRotationSession = nullptr.

s/TODO/FIXME/

> LayoutTests/webrtc/canvas-to-peer-connection.html:80
> +// FIXME: Tthis should be filled when 2D context supports
HTMLCanvasElement.captureStream().

Typo: Tthis