[webkit-reviews] review granted: [Bug 167579] [GTK] WTR: Native HTML form validation popover is not supported : [Attachment 449703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 03:20:14 PST 2022

Carlos Garcia Campos <cgarcia at igalia.com> has granted ChangSeok Oh
<changseok at webkit.org>'s request for review:
Bug 167579: [GTK] WTR: Native HTML form validation popover is not supported

Attachment 449703: Patch


--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 449703
  --> https://bugs.webkit.org/attachment.cgi?id=449703

View in context: https://bugs.webkit.org/attachment.cgi?id=449703&action=review

> Tools/WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:177
> +static Ref<JSON::Object> toJSONObject(GVariant* variant)

Since we always want the string representation, this could return a String
instead of the JSON object.

> Tools/WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:201
> +static JSStringRef toJSStringRef(GVariant* contentDictionary)
> +{
> +    auto jsonObject = toJSONObject(contentDictionary);
> +    return
> +}

And then we don't need this, because we can use WTR::createString()

More information about the webkit-reviews mailing list