[webkit-reviews] review granted: [Bug 235616] [iOS][macOS] Block access to Icon service : [Attachment 449975] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 235616: [iOS][macOS] Block access to Icon service
https://bugs.webkit.org/show_bug.cgi?id=235616

Attachment 449975: Patch

https://bugs.webkit.org/attachment.cgi?id=449975&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 449975
  --> https://bugs.webkit.org/attachment.cgi?id=449975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449975&action=review

> Source/WebKit/ChangeLog:3
> +	   [iOS][macOS] Block access to Icon service

I think it's "Icon Services"

> Source/WebKit/ChangeLog:9
> +	   Stop creating a sandbox extension for the Icon service when the
attachment element is enabled,
> +	   since local testing indicates that this is not needed.

I’m kind of surprised. Maybe we don’t put the icon into <input type=file>
element on the webpage any more, like we did in the past. Did you test with a
file with an unusual icon to make sure the icon was correct?