[webkit-reviews] review granted: [Bug 235610] Build failure with GCC 12: MediaTime.h:167:71: error: call to non-'constexpr' function 'WTF::MediaTime& WTF::MediaTime::operator=(const WTF::MediaTime&)' : [Attachment 449970] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 235610: Build failure with GCC 12: MediaTime.h:167:71: error: call to
non-'constexpr' function 'WTF::MediaTime& WTF::MediaTime::operator=(const
WTF::MediaTime&)'
https://bugs.webkit.org/show_bug.cgi?id=235610

Attachment 449970: Patch

https://bugs.webkit.org/attachment.cgi?id=449970&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 449970
  --> https://bugs.webkit.org/attachment.cgi?id=449970
Patch

This will not be needed once I land the patch in bug 235501, which eliminates
this bad pattern (using operator= to implement a constructor), but it’s OK to
land it now, I guess.

Unless you are wiling to wait