[webkit-reviews] review granted: [Bug 235550] Support workspace builds in build-webkit : [Attachment 449886] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 25 10:00:06 PST 2022

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 235550: Support workspace builds in build-webkit

Attachment 449886: Patch


--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 449886
  --> https://bugs.webkit.org/attachment.cgi?id=449886

View in context: https://bugs.webkit.org/attachment.cgi?id=449886&action=review

r=me. I don't see how the Windows build failure can be caused by this.

> Tools/Scripts/build-webkit:126
> +  --[no-]use-workspace	       Use WebKit.xcworkspace and XCBuild (iOS
and Mac only)

AFAICT this affects watchOS and tvOS too.

More information about the webkit-reviews mailing list